Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photon Style light theme color #24

Closed
black7375 opened this issue Jun 2, 2021 · 3 comments
Closed

Photon Style light theme color #24

black7375 opened this issue Jun 2, 2021 · 3 comments
Labels
Class::Color Color, background, blur, etc. Distribution::Photon-Style Photon style distribution related Priority::Low The importance is low

Comments

@black7375
Copy link
Owner

Is your feature request related to a problem? Please describe.
https://www.reddit.com/r/firefox/comments/nly44l/this_week_proton_fixwill_be_called_lepton_tab/h075uu4?utm_source=share&utm_medium=web2x&context=3

I prefer when all programs has similar design on the system. Windows 10 by default has light titlebars (light theme by default). But Firefox has light controls with dark titlebar (system theme), but it can be fixed by switching to the light theme. And light theme in your fix differs from original photon
u/Yoskaldyr

Describe the solution you'd like
We can consider adjusting color.

Additional context
It's just something to keep in mind.

@black7375 black7375 added Class::Color Color, background, blur, etc. Priority::Low The importance is low Distribution::Photon-Style Photon style distribution related labels Jun 2, 2021
@TurtleDino
Copy link

Plus one-ing this issue. Someone on Reddit said the following. Not sure if it’s related to Photon or Lepton.

“right now it optimized only for dark theme :( light theme is only partially usable :(

I hope in the nearest future it will be fixed for all standard themes (default, dark, light)”

@black7375
Copy link
Owner Author

black7375 commented Jun 5, 2021

Refer for Contrast ratio (3:1)
https://bugzilla.mozilla.org/show_bug.cgi?id=1704347#c25

https://webaim.org/resources/contrastchecker/

@black7375 black7375 mentioned this issue Jul 1, 2021
25 tasks
@black7375
Copy link
Owner Author

It retains feel and add contrast.

:root[lwtheme-mozlightdark][lwthemetextcolor="dark"] {
   --lwt-accent-color: #E5E5EB !important;
}

Before
image

After
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class::Color Color, background, blur, etc. Distribution::Photon-Style Photon style distribution related Priority::Low The importance is low
Projects
None yet
Development

No branches or pull requests

2 participants