Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--tab-line-color should be "highlight" by default on Linux (Photon-style) #120

Closed
3 of 11 tasks
Alex-gnzl opened this issue Jul 12, 2021 · 3 comments
Closed
3 of 11 tasks
Labels
Class::Color Color, background, blur, etc. Component::Tabbar Tab or tabbar Env::Linux Issues on Linux Issue::Bug Something isn't working

Comments

@Alex-gnzl
Copy link

Alex-gnzl commented Jul 12, 2021

Description:
Currently the tab highlight is hardcoded, making it blue on the system theme.

Expected behavior:
Should follow active GTK theme.

Screenshots
Screenshot_20210712_140209
Screenshot_20210712_135431
Screenshot_20210712_140435

Environment:

  • Distribution
  • Firefox Version: 89.0.2
  • OS:
    • Linux
    • Windows
    • Mac
    • Others:
  • Theme:
    • Light
    • Dark
    • Alpenglow(System: Light)
    • Alpenglow(System: Dark)
    • System Default
      • GTK Theme Name(Only Linux User): Breeze GTK

Additional info:
This does not matter for custom themes, only System Default.
https://developer.mozilla.org/en-US/docs/Web/CSS/color_value#system_colors
(i have tested this with Windows 10, and alas it doesn't work there.)

@Alex-gnzl Alex-gnzl added the Issue::Bug Something isn't working label Jul 12, 2021
@black7375 black7375 added Class::Color Color, background, blur, etc. Component::Tabbar Tab or tabbar Env::Linux Issues on Linux labels Jul 12, 2021
@black7375
Copy link
Owner

I was thinking of doing more GTK compatibility work after the dark mode.
For example, URL bar border, etc. should also be GTK highlight color.

Nice report.

@Alex-gnzl
Copy link
Author

Alex-gnzl commented Jul 12, 2021

While I'm at it, might as well specify this:

  • there isn't much jank regarding color otherwise, most things just work
  • urlbar seems to have a highlight border when i open a new tab, but it's darker for some reason (i'm not sure if it's focused or not? it's odd - focused but not unfolded; might be simply broken on my firefox)
    Screenshot_20210712_145312
  • Highlight and HighlightText seem to be the only useful ones out of the bunch (see comparison screenshots between two GTK themes, Breeze (w/ custom colorscheme) and Adwaita Dark)
    Screenshot_20210712_145514
    Screenshot_20210712_145848
  • Changing to a theme that isn't "System Default" does not affect "Highlight", but thankfully --tab-line-color gets overridden to the theme color, so it just works.
  • For me, using Highlight on Windows 10 just defaulted to some blue color, I think? Either way, it's not usable for Windows. Sadly Firefox doesn't support it.

Thank you for this project!

@black7375
Copy link
Owner

Now, GTK Supported at develope verstion!!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class::Color Color, background, blur, etc. Component::Tabbar Tab or tabbar Env::Linux Issues on Linux Issue::Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants