Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dhtslib.vcf.record poor test coverage #94

Closed
jblachly opened this issue Aug 11, 2021 · 1 comment · Fixed by #105
Closed

dhtslib.vcf.record poor test coverage #94

jblachly opened this issue Aug 11, 2021 · 1 comment · Fixed by #105
Assignees

Comments

@jblachly
Copy link
Member

When compiling nanoprof, a dhtslib compile error in dhtslib.vcf.record was noted:

../lib/source/nanoprof/lib/alignment.d(409,41): Deprecation: function dhtslib.sam.reader.SAMReader.targetId is deprecated - u
se these properties from SAMHeader
../../../dhtslib/source/dhtslib/vcf/record.d(599,10): Error: template instance isIntegral!T template isIntegral is not define
d
source/app.d(137,30):        while looking for match for add!("INFO", float[])

This is because std.traits was not in scope for this module, presumably because it was at one time but then record.d brought out into its own module and missed that. I fixed this in f853ff1

HOWEVER, this wasn't picked up in dhtslib CI testing, which means test coverage in vcf.record is poor or nonexistant. @charlesgregory please add a few tests for this module

@jblachly
Copy link
Member Author

https://codecov.io/gh/blachlylab/dhtslib/src/f853ff15fb743f1caff7e976ec726901ec2f999e/source/dhtslib/vcf/record.d

Looks like it was add and addInfo specifically that were totally uncovered, rest of file looks OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants