You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When compiling nanoprof, a dhtslib compile error in dhtslib.vcf.record was noted:
../lib/source/nanoprof/lib/alignment.d(409,41): Deprecation: function dhtslib.sam.reader.SAMReader.targetId is deprecated - u
se these properties from SAMHeader
../../../dhtslib/source/dhtslib/vcf/record.d(599,10): Error: template instance isIntegral!T template isIntegral is not define
d
source/app.d(137,30): while looking for match for add!("INFO", float[])
This is because std.traits was not in scope for this module, presumably because it was at one time but then record.d brought out into its own module and missed that. I fixed this in f853ff1
HOWEVER, this wasn't picked up in dhtslib CI testing, which means test coverage in vcf.record is poor or nonexistant. @charlesgregory please add a few tests for this module
The text was updated successfully, but these errors were encountered:
When compiling nanoprof, a dhtslib compile error in
dhtslib.vcf.record
was noted:This is because std.traits was not in scope for this module, presumably because it was at one time but then record.d brought out into its own module and missed that. I fixed this in f853ff1
HOWEVER, this wasn't picked up in dhtslib CI testing, which means test coverage in
vcf.record
is poor or nonexistant. @charlesgregory please add a few tests for this moduleThe text was updated successfully, but these errors were encountered: