Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema validation for templates #364

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

bkryza
Copy link
Owner

@bkryza bkryza commented Jan 9, 2025

Fixes #361

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.41%. Comparing base (d3f9101) to head (ef84f61).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/config/yaml_decoders.cc 81.25% 3 Missing ⚠️
src/cli/cli_handler.cc 92.85% 2 Missing ⚠️
src/config/yaml_emitters.cc 97.05% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #364      +/-   ##
==========================================
+ Coverage   90.25%   90.41%   +0.16%     
==========================================
  Files         151      151              
  Lines       18020    18065      +45     
==========================================
+ Hits        16264    16334      +70     
+ Misses       1756     1731      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkryza bkryza merged commit 6f08406 into master Jan 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue in using include for diagram template
1 participant