Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish on GH tag #32

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Publish on GH tag #32

merged 1 commit into from
Jan 9, 2024

Conversation

evman182
Copy link
Collaborator

@evman182 evman182 commented Jan 5, 2024

No description provided.

@evman182 evman182 requested a review from bkroeker January 5, 2024 21:06
@bkroeker
Copy link
Owner

bkroeker commented Jan 5, 2024

Can you describe how this works to me? Do we need to connect github to rubygems's authorized list somehow? How can we be sure that a tag was a release tag and not some other random tag?

@evman182
Copy link
Collaborator Author

evman182 commented Jan 5, 2024

@bkroeker The tag would have to start with v, but we can tweak it to make it more specific than that. In terms of RubyGems, you'll need to add an API key to the secrets for the repo. I don't think I can do it since you own the repo. Then I'll probably need to tweak the workflow a bit to get it to use the credentials correctly

@evman182
Copy link
Collaborator Author

evman182 commented Jan 8, 2024

Actually, looks like we can make probably make GHA a trusted published. Will look into it a bit

@evman182
Copy link
Collaborator Author

evman182 commented Jan 8, 2024

Updated to use the official rubygems publisher action. trusted publisher is setup on rubygems as well

Copy link
Owner

@bkroeker bkroeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, looks good!

@evman182 evman182 merged commit 526f8d7 into bkroeker:master Jan 9, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants