Skip to content

Commit

Permalink
Add cloudflare record to enable deletion whitelist. (app-sre#3260)
Browse files Browse the repository at this point in the history
  • Loading branch information
OliviaHY authored and bkez322 committed Jul 13, 2023
1 parent e06966b commit 86ac282
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion reconcile/utils/terraform_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ def log_plan_diff(
) -> tuple[bool, list]:
disabled_deletion_detected = False
account_enable_deletion = self.accounts[name].get("enableDeletion") or False
# deletions are alowed
# deletions are allowed
# if enableDeletion is true for an account
# or if the integration's enable_deletion is true
deletions_allowed = enable_deletion or account_enable_deletion
Expand Down Expand Up @@ -267,6 +267,7 @@ def log_plan_diff(
always_enabled_deletions = {
"random_id",
"aws_lb_target_group_attachment",
"cloudflare_record", # This is because a zone can contain up to one thousand records and it's not practical to require adding each record to deletionApprovals
}

# https://www.terraform.io/docs/internals/json-format.html
Expand Down

0 comments on commit 86ac282

Please sign in to comment.