Skip to content

Commit

Permalink
Added comments on issues raised by Jacob Dean.
Browse files Browse the repository at this point in the history
  • Loading branch information
bjmorgan committed Jul 5, 2021
1 parent afb4475 commit a056ecd
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions pyscses/set_up_calculation.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ def site_from_input_file(site,
:obj:`Site`
"""

label = site[0]
if site_charge == True:
valence = float(site[1])
Expand All @@ -33,6 +34,11 @@ def site_from_input_file(site,
defect_labels = site[3::2]
defect_energies = [ float(e) for e in site[4::2] ]
min_energy = min(defect_energies)
# TODO: **Not well-defined what this is *supposed* to do.**
# TODO: Intended to define the core as being a single plane versus multiple planes.
# TODO: For multiple planes consider everything with |E_seg| < kT.
# TODO: For single plane, what is the intended behaviour if we have >1 site with the
# TODO: **same** lowest segregation energy?
if core == 'single':
for d_e in defect_energies:
if d_e > min_energy:
Expand Down

0 comments on commit a056ecd

Please sign in to comment.