Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add warning handler for overflows #30

Merged
merged 2 commits into from
May 11, 2023
Merged

add warning handler for overflows #30

merged 2 commits into from
May 11, 2023

Conversation

alexsquires
Copy link
Collaborator

addressing #29

@alexsquires alexsquires requested a review from bjmorgan May 10, 2023 16:00
@bjmorgan
Copy link
Owner

I've never written custom warning code myself, but I think this looks good.
Does the custom warning code need an else clause that raises the original warning if it does not match either condition, or is that impossible?
Ideally there would be unit tests that test triggering of these two custom warning types.

@alexsquires alexsquires merged commit d3dc69e into main May 11, 2023
@alexsquires
Copy link
Collaborator Author

closes #29

@alexsquires alexsquires deleted the warning_handling branch May 18, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants