Skip to content

Commit

Permalink
fix: envoy shutdown flaky test (envoyproxy#3646)
Browse files Browse the repository at this point in the history
delay readdiness to allow XDS sync

Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: “bjlhlin” <“[email protected]”>
Signed-off-by: bjlhlin <[email protected]>
  • Loading branch information
guydc authored and bjlhlin committed Jun 24, 2024
1 parent f1ed4fe commit 622ae44
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
10 changes: 10 additions & 0 deletions test/config/gatewayclass.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,16 @@ spec:
kubernetes:
envoyDeployment:
replicas: 2
patch:
type: StrategicMerge
value:
spec:
template:
spec:
containers:
- name: envoy
readinessProbe:
initialDelaySeconds: 5
---
kind: GatewayClass
apiVersion: gateway.networking.k8s.io/v1
Expand Down
3 changes: 1 addition & 2 deletions test/e2e/upgrade/eg_upgrade_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,7 @@ func TestEGUpgrade(t *testing.T) {
// All e2e tests should leave Features empty.
SupportedFeatures: sets.New[features.SupportedFeature](features.SupportGateway),
SkipTests: []string{
tests.EnvoyShutdownTest.ShortName, // https://github.com/envoyproxy/gateway/issues/3262
tests.EGUpgradeTest.ShortName, // https://github.com/envoyproxy/gateway/issues/3311
tests.EGUpgradeTest.ShortName, // https://github.com/envoyproxy/gateway/issues/3311
},
})
if err != nil {
Expand Down

0 comments on commit 622ae44

Please sign in to comment.