-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stylelint v14 Compatibility #197
Conversation
* stylelint-order: 4.0.0 --> 5.0.0 * stylelint-scss: 3.18.0 --> 4.0.0 * stylelint: 13.7.0 --> 14.0.0 * tape: 5.0.1 --> 5.3.1 For compatibility with stylelint@v14: * Sync "node" compatibility * (tape) Add "postcss-scss" as devDependency * (tape) Update test in "url-quotes.js" Closes: bjankord#195 Closes: bjankord#196
Not having changes to use the new |
Given that this repository is pretty much a configuration of existing rules, I don't see where it would be needed. |
Well, in stylelint 14, stylelint does not support parsing scss files if the config does not configure the |
True, but I would expect that the end user configures I generally would not rely on the library to do that for me. |
Well, this config cannot be used without it. So why would it force the user to do it themselves ? That's the opposite of reusable configs. |
And having the config specific for a syntax specify that |
Fair enough. Pushed a commit to address. |
7fc0d5d
to
3f62a4e
Compare
This looks good to me, all tests pass. Thanks for the PR @gfyoung and thanks for the discussion @stof The node 10 tests failing is expected since we're dropping that from the engines list. I'll work on updating the GitHub Actions to no longer run tests on node 10. I'll plan on getting a new major version for this repo cut soon. |
This has been released in v9.0.0. I also added the hacktoberfest topic to this repo, so if you are participating in that, you should get credit for this PR. Thanks again for the contribution @gfyoung and for the code review @stof! |
Updates will also supersede the following PRs:
Closes: #195
Closes: #196