Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #24 crash when keys were removed from a map #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes #24 crash when keys were removed from a map #25

wants to merge 1 commit into from

Conversation

cvogt
Copy link
Contributor

@cvogt cvogt commented Mar 30, 2017

No description provided.

@hderms
Copy link

hderms commented Sep 25, 2018

would be great to get this merged. We had to vendor the library and make the change ourselves because it was preventing us from using it properly.

@cvogt
Copy link
Contributor Author

cvogt commented Sep 25, 2018

@caente if I could get back merge rights, I would do it :)

@caente
Copy link
Contributor

caente commented Oct 15, 2018

hey sorry the delay, I was on vacation! what do you think about adding a test that replicates the issue?

@mirelon
Copy link

mirelon commented Jun 4, 2021

I will continue on this in #29

@mirelon
Copy link

mirelon commented Jun 4, 2021

I have added some tests. They were failing before the fix (this one: diff(Map("a" -> "b", "c" -> "d"),Map("a" -> "b"))). With the fix they run OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cvogt @hderms @caente @mirelon