Assert that completeTransactions() was called when the app launches. #337
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
completeTransactions()
was called when the app launches.Related issue: #287.
Discussion
This PR adds a runtime assertion to check that
completeTransactions()
was called when the app launches. The assertion is checked when callingpurchaseProduct()
orrestorePurchases()
, as these calls are most likely to yield undesired results without a prior call tocompleteTransactions()
.A better way of doing this would be to transform the runtime check into a compile-time constraint.
This could be done by making the
CompleteTransactions
struct a non-optional parameter passed to the initializer of SwiftyStoreKit. Example:This would require SwiftyStoreKit to not be a singleton, which would be a big API-breaking change that affects all clients.
For the time being - I will keep this as a runtime check. Hopefully this is enough to prevent problems down the line in testing.