-
Notifications
You must be signed in to change notification settings - Fork 797
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #259 from bizz84/bugfix/ProductsInfoController-mul…
…tiple-completion-blocks ProductsInfoController: Keep track of multiple completion blocks for the same request
- Loading branch information
Showing
4 changed files
with
175 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,120 @@ | ||
| // | ||
| // ProductsInfoControllerTests.swift | ||
| // SwiftyStoreKit | ||
| // | ||
| // Copyright (c) 2017 Andrea Bizzotto ([email protected]) | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| // of this software and associated documentation files (the "Software"), to deal | ||
| // in the Software without restriction, including without limitation the rights | ||
| // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| // copies of the Software, and to permit persons to whom the Software is | ||
| // furnished to do so, subject to the following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included in | ||
| // all copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| // THE SOFTWARE. | ||
|
|
||
| import XCTest | ||
| @testable import SwiftyStoreKit | ||
|
|
||
| class TestInAppProductRequest: InAppProductRequest { | ||
|
|
||
| private let productIds: Set<String> | ||
| private let callback: InAppProductRequestCallback | ||
|
|
||
| init(productIds: Set<String>, callback: @escaping InAppProductRequestCallback) { | ||
| self.productIds = productIds | ||
| self.callback = callback | ||
| } | ||
|
|
||
| func start() { | ||
|
|
||
| } | ||
| func cancel() { | ||
|
|
||
| } | ||
|
|
||
| func fireCallback() { | ||
| callback(RetrieveResults(retrievedProducts: [], invalidProductIDs: [], error: nil)) | ||
| } | ||
| } | ||
|
|
||
| class TestInAppProductRequestBuilder: InAppProductRequestBuilder { | ||
|
|
||
| var requests: [ TestInAppProductRequest ] = [] | ||
|
|
||
| func request(productIds: Set<String>, callback: @escaping InAppProductRequestCallback) -> InAppProductRequest { | ||
| let request = TestInAppProductRequest(productIds: productIds, callback: callback) | ||
| requests.append(request) | ||
| return request | ||
| } | ||
|
|
||
| func fireCallbacks() { | ||
| requests.forEach { | ||
| $0.fireCallback() | ||
| } | ||
| requests = [] | ||
| } | ||
| } | ||
|
|
||
| class ProductsInfoControllerTests: XCTestCase { | ||
|
|
||
| let sampleProductIdentifiers: Set<String> = ["com.iap.purchase1"] | ||
|
|
||
| func testRetrieveProductsInfo_when_calledOnce_then_completionCalledOnce() { | ||
|
|
||
| let requestBuilder = TestInAppProductRequestBuilder() | ||
| let productInfoController = ProductsInfoController(inAppProductRequestBuilder: requestBuilder) | ||
|
|
||
| var completionCount = 0 | ||
| productInfoController.retrieveProductsInfo(sampleProductIdentifiers) { _ in | ||
| completionCount += 1 | ||
| } | ||
| requestBuilder.fireCallbacks() | ||
|
|
||
| XCTAssertEqual(completionCount, 1) | ||
| } | ||
|
|
||
| func testRetrieveProductsInfo_when_calledTwiceConcurrently_then_eachCompletionCalledOnce() { | ||
|
|
||
| let requestBuilder = TestInAppProductRequestBuilder() | ||
| let productInfoController = ProductsInfoController(inAppProductRequestBuilder: requestBuilder) | ||
|
|
||
| var completionCount = 0 | ||
| productInfoController.retrieveProductsInfo(sampleProductIdentifiers) { _ in | ||
| completionCount += 1 | ||
| } | ||
| productInfoController.retrieveProductsInfo(sampleProductIdentifiers) { _ in | ||
| completionCount += 1 | ||
| } | ||
| requestBuilder.fireCallbacks() | ||
|
|
||
| XCTAssertEqual(completionCount, 2) | ||
| } | ||
| func testRetrieveProductsInfo_when_calledTwiceNotConcurrently_then_eachCompletionCalledOnce() { | ||
|
|
||
| let requestBuilder = TestInAppProductRequestBuilder() | ||
| let productInfoController = ProductsInfoController(inAppProductRequestBuilder: requestBuilder) | ||
|
|
||
| var completionCount = 0 | ||
| productInfoController.retrieveProductsInfo(sampleProductIdentifiers) { _ in | ||
| completionCount += 1 | ||
| } | ||
| requestBuilder.fireCallbacks() | ||
| XCTAssertEqual(completionCount, 1) | ||
|
|
||
| productInfoController.retrieveProductsInfo(sampleProductIdentifiers) { _ in | ||
| completionCount += 1 | ||
| } | ||
| requestBuilder.fireCallbacks() | ||
| XCTAssertEqual(completionCount, 2) | ||
| } | ||
| } |