Restructure node and change protobuf generation location #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridger-herman
requested review from
peterschwarz,
vaporos,
jsmitchell,
agunde406 and
aludvik
bridger-herman
force-pushed
the
restructure
branch
from
aa95711
to
de9505f
Compare
agunde406
approved these changes
Aug 28, 2018
bridger-herman
force-pushed
the
restructure
branch
from
de9505f
to
ecda92a
Compare
added 3 commits
August 31, 2018 11:19
Individual message handlers now are in their own file, as opposed to being tacked onto the end of PbftNode. Adds a test for individual handlers. Signed-off-by: Bridger Herman <[email protected]>
Changes PbftNotReadyType to PbftHint, and explicitly defines "future," "past," and "present" messages. Adds tests for determining PbftHints from PbftState. Signed-off-by: Bridger Herman <[email protected]>
The old method of generating protobuf code inside the src directory is no longer supported in Rust 1.28: https://blog.rust-lang.org/2018/08/02/Rust-1.28.html Signed-off-by: Bridger Herman <[email protected]>
bridger-herman
force-pushed
the
restructure
branch
from
ecda92a
to
adbfa66
Compare
vaporos
approved these changes
Aug 31, 2018
ltseeley
added a commit
to ltseeley/sawtooth-pbft
that referenced
this pull request
Nov 19, 2018
…ng-usage Update message signing usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced:
node.rsintohandlers.rssrcdirectory