[PM-336] Enable Nullable In Unowned Services

[justindbaur]

🎟️ Tracking

📔 Objective

Enable nullable in un-owned services in the Core project. I made changes to have as little impact to business logic as possible.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

Attention: Patch coverage is 22.35294% with 66 lines in your changes missing coverage. Please review.

Project coverage is 42.47%. Comparing base (53ad9df) to head (f485b33).

Files with missing lines	Patch %	Lines
...e/Services/Implementations/StripePaymentService.cs	22.85%	27 Missing ⚠️
src/Core/Services/Implementations/UserService.cs	14.28%	17 Missing and 1 partial ⚠️
...tityFramework/Repositories/CollectionRepository.cs	0.00%	6 Missing ⚠️
src/Core/Models/PushNotification.cs	0.00%	3 Missing ⚠️
...vices/Implementations/BaseIdentityClientService.cs	62.50%	2 Missing and 1 partial ⚠️
...Core/Services/Implementations/I18nViewLocalizer.cs	0.00%	3 Missing ⚠️
src/Core/Services/Implementations/I18nService.cs	0.00%	2 Missing ⚠️
...rvices/NoopImplementations/NoopLicensingService.cs	0.00%	2 Missing ⚠️
...Core/Services/Implementations/CollectionService.cs	0.00%	1 Missing ⚠️
.../Services/Implementations/HandlebarsMailService.cs	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4748      +/-   ##
==========================================
- Coverage   42.47%   42.47%   -0.01%     
==========================================
  Files        1386     1386              
  Lines       64625    64635      +10     
  Branches     5931     5934       +3     
==========================================
+ Hits        27449    27451       +2     
- Misses      35952    35960       +8     
  Partials     1224     1224              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coroiu]

Ouf 58 files. I'm just gonna approve and assume that the compiler knows what it's doing

[github-actions]

Checkmarx One – Scan Summary & Details – 0162761e-5878-45f5-aab7-2cfc3bef706f

No New Or Fixed Issues Found