-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-1191] collections cannot be managed in family organization #2765
[PM-1191] collections cannot be managed in family organization #2765
Conversation
EF6 is currently not able to translate LINQ that include selects after groupby statements. Using join let's us bypass this issue.
@coroiu Maybe I am missing something but isn't this now saying every collection has access groups and users associated to it if ANY do? I have a group that only has the Default Collection: But two collection show that they have that group assigned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above concern
This reverts commit f57443d.
Nice catch, should be fixed now! Guess I “simplified queries” a bit too much 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks.
If these changes were approved why are they not being pulled into the dev build? |
@cvondra waiting for QA, if vault team has different processes then feel free to merge :) |
@justindbaur any idea on the QA status of this? |
@coroiu Part of the reason that unified is in beta is because QA doesn't have infrastructure or capacity to test each feature branch right now for EF databases. Since this is an EF change only and I ran it locally we can just merge this. @cvondra I'm going to merge this now and it will be in the |
Latest push to /dev works perfectly. |
Type of change
Objective
Fix issue reported by users that org vault is broken after OAVR v2 when using EF.
Fixes #2750
Code changes
EF6 is currently not able to translate LINQ that include selects after
group
statements (see github issue). Usingjoin
let's us bypass this issue.This new solution is probably a bit faster too so win-win :)
Before you submit
dotnet format --verify-no-changes
) (required)