Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PS-2195] Provide webfonts #2570

Merged
merged 1 commit into from
Jan 19, 2023
Merged

[PS-2195] Provide webfonts #2570

merged 1 commit into from
Jan 19, 2023

Conversation

MGibson1
Copy link
Member

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Fixes #2549. Provides webfont assets to Admin.

Code changes

  • gulp: Move webfonts to wwwroot
  • webfonts.scss: move to scss because that's the matcher for sass in our gulpfie

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@MGibson1 MGibson1 requested a review from a team January 12, 2023 16:56
@justindbaur justindbaur changed the title Provide webfonts [PS-2195] Provide webfonts Jan 12, 2023
Copy link
Member

@justindbaur justindbaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this would be broken for standard deployment too?

@MGibson1
Copy link
Member Author

yeah, and we have a duplicate ticket for prod too

@MGibson1 MGibson1 enabled auto-merge (squash) January 19, 2023 18:48
@MGibson1 MGibson1 merged commit 01b4a4d into master Jan 19, 2023
@MGibson1 MGibson1 deleted the ps/ps-2195-fix-webfonts branch January 19, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing asset /admin/css/webfonts.css
2 participants