change unified to debian images #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgrassia
requested changes
Jan 3, 2023
Co-authored-by: Vince Grassia <[email protected]>
Co-authored-by: Vince Grassia <[email protected]>
vgrassia
approved these changes
Jan 5, 2023
cyprain-okeke
pushed a commit
that referenced
this pull request
Jan 5, 2023
* change to debian images * add back sqlite connectionstring * add back sqlite connection string * Update docker-unified/entrypoint.sh Co-authored-by: Vince Grassia <[email protected]> * Update docker-unified/entrypoint.sh Co-authored-by: Vince Grassia <[email protected]> * update settings * uid requires # Co-authored-by: Vince Grassia <[email protected]>
cyprain-okeke
added a commit
that referenced
this pull request
Jan 6, 2023
* change to debian images * add back sqlite connectionstring * add back sqlite connection string * Update docker-unified/entrypoint.sh Co-authored-by: Vince Grassia <[email protected]> * Update docker-unified/entrypoint.sh Co-authored-by: Vince Grassia <[email protected]> * update settings * uid requires # Co-authored-by: Vince Grassia <[email protected]>
1 task
eliykat
pushed a commit
that referenced
this pull request
Jan 10, 2023
* change to debian images * add back sqlite connectionstring * add back sqlite connection string * Update docker-unified/entrypoint.sh Co-authored-by: Vince Grassia <[email protected]> * Update docker-unified/entrypoint.sh Co-authored-by: Vince Grassia <[email protected]> * update settings * uid requires # Co-authored-by: Vince Grassia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
.NET Core has issues with Sqlite libraries on alpine images. In order to support reliable sqlite usage, we need to move to something else, like Debian. This PR makes the change to debian images.
Code changes
bashinstead ofshin order to get some commands, like the openssl ones, to run. Bash squats on UID and GID already, so switch variables to match those of other popular linuxserver.io images, using PUID, and PGID.Before you submit
dotnet format --verify-no-changes) (required)