[DEVOPS-1751] Pipeline for publishing java sdk to gradle #740

michalchecinski · 2024-04-26T10:59:08Z

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [x] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Code changes

.github/workflows/build-java.yml: Run build on rc and hotfix-rc and on PR. Change Publish task to package.
.github/workflows/publish-java.yml Add Publish workflow
.github/workflows/version-bump.yml Add Java SDK to version bump workflow
languages/java/build.gradle Change name of the package to sdk-secrets. Add https://s01.oss.sonatype.org/service/local/staging/deploy/maven2/ as repository to publish.

Before you submit

Please add unit tests where it makes sense to do so

… job

… step

github-actions · 2024-04-26T11:03:43Z

Checkmarx One – Scan Summary & Details – ce1aa135-8a69-4008-8ca8-ed4226f20709

New Issues

Severity	Issue	Source File / Package	Checkmarx Insight
	Unpinned Actions Full Length Commit SHA	/version-bump.yml: 54	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
	Unpinned Actions Full Length Commit SHA	/publish-java.yml: 60	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity	Issue	Source File / Package
	Unpinned Actions Full Length Commit SHA	/version-bump.yml: 53

codecov · 2024-04-26T11:04:34Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.69%. Comparing base (37dc5d3) to head (9116ee0).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #740   +/-   ##
=======================================
  Coverage   58.69%   58.69%           
=======================================
  Files         177      177           
  Lines       11501    11501           
=======================================
  Hits         6751     6751           
  Misses       4750     4750

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mzieniukbw

~~I don't think the intention was to make this Java sdk to be Secrets Manager specific.~~
See below for my other comments

mzieniukbw · 2024-04-26T20:53:10Z

.github/workflows/build-java.yml

        uses: gradle/actions/setup-gradle@ec92e829475ac0c2315ea8f9eced72db85bb337a # v3.0.0
        with:
-          arguments: publish
+          arguments: package
          build-root-directory: languages/java
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}


i don't think we need the token here anymore

Right! Good catch.

mzieniukbw · 2024-04-26T20:59:41Z

.github/workflows/build-java.yml

        uses: gradle/actions/setup-gradle@ec92e829475ac0c2315ea8f9eced72db85bb337a # v3.0.0
        with:
-          arguments: publish
+          arguments: package


this is probably unsupported by this action, since it's more for setup of gradle, rather than execution.
You need a separate step like: (also there is no "package" in gradle, but there is "build"

- name: Build Maven run: ./gradlew build

mzieniukbw · 2024-04-26T21:03:37Z

languages/java/build.gradle

We should publish with java docs (and optionally source code), maybe add:

java { withJavadocJar() withSourcesJar() }

mzieniukbw · 2024-04-26T21:10:21Z

languages/java/build.gradle

    java.sourceCompatibility = JavaVersion.VERSION_1_8

    publishing {
        publications {
            maven(MavenPublication) {
                groupId = 'com.bitwarden'
-                artifactId = 'sdk'
+                artifactId = 'sdk-secrets'


~~i though this sdk repo is not specific to secrets manager, but it's for everyone ?~~
I did not know the Bitwarden SDK / this repo is just for secrets manager, so this change make sense now.

mimartin12

Nothing from my side that @mzieniukbw hasn't already by brought up 👍

…-to-Gradle

mzieniukbw

lgtm

…-to-Gradle

michalchecinski added 9 commits April 24, 2024 17:42

Update java sdk to version bump

9a28e77

Update build.gradle file

eec8e65

Update build-java.yml workflow file and fix publish argument in Maven…

74a1270

… job

Change for package

30d35c7

Add publish java pipeline

7b4f738

Update Azure login and retrieve secrets in publish-java workflow

0e14859

Update secrets in publish-java workflow

76379f0

Update Maven credentials in publish-java workflow

77a35ad

Update publish-java workflow to conditionally run the package publish…

1859d3e

… step

michalchecinski requested a review from a team as a code owner April 26, 2024 10:59

michalchecinski requested a review from mzieniukbw April 26, 2024 10:59

mzieniukbw requested changes Apr 26, 2024

View reviewed changes

mimartin12 reviewed May 1, 2024

View reviewed changes

michalchecinski added 3 commits May 7, 2024 13:49

Fix

9916f55

Update build.gradle file to include Javadoc and sources JAR generation

5472112

Merge branch 'main' into DEVOPS-1751-Pipeline-for-publishing-Java-SDK…

2a4ae73

…-to-Gradle

mzieniukbw approved these changes May 7, 2024

View reviewed changes

michalchecinski requested review from mimartin12 and mzieniukbw May 8, 2024 08:40

michalchecinski enabled auto-merge (squash) May 8, 2024 09:31

mzieniukbw previously approved these changes May 10, 2024

View reviewed changes

Merge branch 'main' into DEVOPS-1751-Pipeline-for-publishing-Java-SDK…

9116ee0

…-to-Gradle

michalchecinski dismissed mzieniukbw’s stale review via 9116ee0 May 10, 2024 09:37

mimartin12 approved these changes May 10, 2024

View reviewed changes

michalchecinski merged commit f01c270 into main May 10, 2024
93 checks passed

michalchecinski deleted the DEVOPS-1751-Pipeline-for-publishing-Java-SDK-to-Gradle branch May 10, 2024 14:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DEVOPS-1751] Pipeline for publishing java sdk to gradle #740

[DEVOPS-1751] Pipeline for publishing java sdk to gradle #740

michalchecinski commented Apr 26, 2024

github-actions bot commented Apr 26, 2024 •

edited

Loading

codecov bot commented Apr 26, 2024 •

edited

Loading

mzieniukbw left a comment •

edited

Loading

mzieniukbw Apr 26, 2024

michalchecinski May 7, 2024

mzieniukbw Apr 26, 2024

michalchecinski May 7, 2024

mzieniukbw Apr 26, 2024

mzieniukbw Apr 26, 2024 •

edited

Loading

mimartin12 left a comment

mzieniukbw left a comment

[DEVOPS-1751] Pipeline for publishing java sdk to gradle #740

[DEVOPS-1751] Pipeline for publishing java sdk to gradle #740

Conversation

michalchecinski commented Apr 26, 2024

Type of change

Objective

Code changes

Before you submit

github-actions bot commented Apr 26, 2024 • edited Loading

New Issues

Fixed Issues

codecov bot commented Apr 26, 2024 • edited Loading

Codecov Report

mzieniukbw left a comment • edited Loading

Choose a reason for hiding this comment

mzieniukbw Apr 26, 2024

Choose a reason for hiding this comment

michalchecinski May 7, 2024

Choose a reason for hiding this comment

mzieniukbw Apr 26, 2024

Choose a reason for hiding this comment

michalchecinski May 7, 2024

Choose a reason for hiding this comment

mzieniukbw Apr 26, 2024

Choose a reason for hiding this comment

mzieniukbw Apr 26, 2024 • edited Loading

Choose a reason for hiding this comment

mimartin12 left a comment

Choose a reason for hiding this comment

mzieniukbw left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 26, 2024 •

edited

Loading

codecov bot commented Apr 26, 2024 •

edited

Loading

mzieniukbw left a comment •

edited

Loading

mzieniukbw Apr 26, 2024 •

edited

Loading