Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release #3294

Merged
merged 9 commits into from
Jun 13, 2024
Merged

Fix release #3294

merged 9 commits into from
Jun 13, 2024

Conversation

michalchecinski
Copy link
Contributor

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

bitwarden/gh-actions/download-artifacts doesn't unpack artifacts into subfolders. Because of it, the Prep Bitwarden iOS release asset step couldn't find the folder to zip. As a solution, I set the bitwarden/gh-actions/download-artifacts to skip unpacking artifacts, and unzipped them individually.

Code changes

  • .github/workflows/release.yml: Skip unpack afrifacts automatically after download. Unzip artifacts individually instead.

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@michalchecinski michalchecinski enabled auto-merge (squash) June 13, 2024 15:37
@michalchecinski michalchecinski merged commit 08ed70d into main Jun 13, 2024
@michalchecinski michalchecinski deleted the fix-release branch June 13, 2024 15:40
michalchecinski added a commit that referenced this pull request Jun 13, 2024
(cherry picked from commit 08ed70d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants