Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-11420] Fix app taking long time to open on poor connectivity. #878

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

fedemkr
Copy link
Member

@fedemkr fedemkr commented Aug 28, 2024

🎟️ Tracking

PM-11420

📔 Objective

Fix issue where the app was taking a lot of time to open appearing to be frozen on the splash screen when having poor connectivity.
This was done by moving to background getting the config from server when is not being forced to refresh. So now the AppProcessor and any other place (where the caller doesn't force refresh) are getting the local config immediately and getting the server config on a background task so it's available for the next time is requested.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

…s not being forced to be refreshed. This was causing the app to appear as frozen on loading because of the call to the getConfig from the AppProcessor and also other places to take longer to load when getting feature flags.
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.71%. Comparing base (f41548e) to head (57b66de).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #878   +/-   ##
=======================================
  Coverage   88.70%   88.71%           
=======================================
  Files         617      617           
  Lines       30804    30812    +8     
=======================================
+ Hits        27326    27335    +9     
+ Misses       3478     3477    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Aug 28, 2024

Logo
Checkmarx One – Scan Summary & Details5551605a-277e-4b06-b0c1-be7c66b4275e

No New Or Fixed Issues Found

@fedemkr fedemkr requested review from matt-livefront and a team August 28, 2024 20:29
Copy link
Collaborator

@matt-livefront matt-livefront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@fedemkr fedemkr merged commit 008c962 into main Aug 28, 2024
8 checks passed
@fedemkr fedemkr deleted the pm-11420/fix-app-frozen-network-condition branch August 28, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants