Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-15119] Fix SSH Key item cloning issue #1156

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

fedemkr
Copy link
Member

@fedemkr fedemkr commented Nov 21, 2024

🎟️ Tracking

PM-15119

📔 Objective

Fix SSH key item should be able to be cloned.
Additionally, enabled ssh-key-vault-item feature flag to be remotely configured.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

… enabled the ssh-key-vault-item to be remotely configured.
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.38%. Comparing base (1f97eab) to head (9f7e11b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1156      +/-   ##
==========================================
- Coverage   89.38%   89.38%   -0.01%     
==========================================
  Files         688      688              
  Lines       43734    43741       +7     
==========================================
+ Hits        39090    39096       +6     
- Misses       4644     4645       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsa8101730-cbf2-481c-9735-0f13a858e428

No New Or Fixed Issues Found

@fedemkr fedemkr merged commit 8293def into main Nov 21, 2024
9 checks passed
@fedemkr fedemkr deleted the PM-15119/fix-ssh-key-item-clone branch November 21, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants