Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14425] [BEEEP] Add test plans #1106

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[PM-14425] [BEEEP] Add test plans #1106

wants to merge 5 commits into from

Conversation

fedemkr
Copy link
Member

@fedemkr fedemkr commented Nov 1, 2024

🎟️ Tracking

PM-14425

📔 Objective

Add test plans so we can separate unit vs snapshot tests vs all tests.

Note:

Before the generate_test_plans.sh is used, make sure to run the next command on the root folder so the changes in the test plans are not tracked by git so the test plans changes remain locally. Therefore there is less possibility of merge conflicts and there's no need to keep the files updated remotely as they can be automatically generated.

git update-index --skip-worktree TestPlans/TestPlan-Snapshot.xctestplan TestPlans/TestPlan-Unit.xctestplan

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Nov 15, 2024

Logo
Checkmarx One – Scan Summary & Detailsc3e36eb0-ce9f-471c-8a05-e0c7ab44c704

No New Or Fixed Issues Found

TEST_PLAN_SNAPSHOT_PATH="TestPlans/TestPlan-Snapshot.xctestplan"
SNAPSHOT_TESTS_TARGET="BitwardenSharedTests"

mint install atakankarsli/[email protected]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've decided not to include the installation of xctestplanner in the Mintfile so it's only installed when actually being used. For now this script won't be called in CI/CD so there's no need to waste time installing xctestplanner .

@fedemkr fedemkr marked this pull request as ready for review November 15, 2024 19:58
Copy link
Collaborator

@matt-livefront matt-livefront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool!

A few questions from me:

  • I'm seeing a few date/time failures in the tests. It looks like we previously set TZ=UTC as an environment variable. Could you add that to the test plans?
  • We used to have a splash screen that showed while testing. That relies on a -testing argument passed on launch, could you add that?
  • Should your comment for git update-index --skip-worktree TestPlans/TestPlan-Snapshot.xctestplan TestPlans/TestPlan-Unit.xctestplan be documented in the README?

Previous test settings:

Screenshot 2024-11-20 at 4 01 54 PM

It looks like the test plans don't include the Networking target, could you include that? I think that's why the test counts are different.

Screenshot 2024-11-20 at 4 31 48 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants