PM-12051: Fix sync error after logout and switch accounts

[matt-livefront]

🎟️ Tracking

PM-12051

📔 Objective

Fixes an issue with automatic account switching when logging out if the two accounts are in separate environments.

• Account A logged into environment X
• Account B logged into environment Y
• If account A logs out, the app will automatically switches to account B. When this occurred, the environment service wasn't loading the URLs for account B/environment Y. This caused any future networking requests to fail for account B in the current session.

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[matt-livefront]

This logic here is the same as what's below, without the call to authRepository.setActiveAccount().

As far as I can tell, this was put in originally as a shortcut if you attempted to switch accounts to the already active account, then it would skip the setActiveAccount() call. However, this causes issues because we also have logic in StateService that makes the next account active when logging out. So what would happen in this scenario, is the first account would logout, StateService would make the next account active and eventually this switchAccountRedirect would be called. Since StateService has already updated the active account, this would skip the authRepository.setActiveAccount call, which does a few other things like reloads the URLs in the environment service. So I think it's better if we always call setActiveAccount() here. We have checks in place in the profile switcher if you try to switch to the already active account, so I couldn't find a scenario where this would be called and you wouldn't want to call setActiveAccount().

ios/BitwardenShared/Core/Platform/Services/StateService.swift

Lines 1531 to 1533 in aa70a30

	if state.activeUserId == knownUserId, userInitiated {
	// Find the next account to make the active account.
	state.activeUserId = state.accounts.first?.key

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.34%. Comparing base (defdd8d) to head (aa70a30).
Report is 5 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1100   +/-   ##
=======================================
  Coverage   89.34%   89.34%           
=======================================
  Files         677      677           
  Lines       42771    42760   -11     
=======================================
- Hits        38214    38205    -9     
+ Misses       4557     4555    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.