Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-14350 - Update copy and generate icons #1097

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

phil-livefront
Copy link
Collaborator

@phil-livefront phil-livefront commented Oct 31, 2024

🎟️ Tracking

PM-14350

📔 Objective

  • Update the copy and generate 24x24 icons. During a design audit this was requested by design.
  • Snapshots didn't get recreated because I am guessing the change wasn't enough to trigger the previous snapshot to fail.

📸 Screenshots

Simulator Screenshot - iPhone 16 Pro - 2024-10-31 at 13 37 14

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.36%. Comparing base (bc0356a) to head (877b964).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1097   +/-   ##
=======================================
  Coverage   89.36%   89.36%           
=======================================
  Files         677      677           
  Lines       42817    42817           
=======================================
  Hits        38262    38262           
  Misses       4555     4555           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phil-livefront phil-livefront marked this pull request as ready for review October 31, 2024 23:42
@phil-livefront phil-livefront merged commit 70b9eb6 into main Nov 1, 2024
9 checks passed
@phil-livefront phil-livefront deleted the phil/PM-14350-update-copy-and-generate-icons branch November 1, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants