Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BITAU-177] Add Default for accountDomain #1088

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

brant-livefront
Copy link
Collaborator

🎟️ Tracking

BITAU-177

📔 Objective

In the Authenticator app, we use accountEmail and accountDomain to format the user's section heading to show them where the specifics codes came from in the PM app. As we were building that, I noticed that accountEmail should really never be nil and made the change to fetch it so that it always has a value. Similarly, account.settings.environmentUrls?.webVaultHost should likely not be nil, but elsewhere in the app we additionally add a fallback value of Constants.defaultWebVaultHost.

I had made a Jira ticket to move both accountEmail and accountDomain to be non-optional in our data model. However, I don't think we need to take that drastic a step and it would cause issues with the temporary item implementation. But I did want to put up this PR to make sure we provide the fallback value just in case.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.52%. Comparing base (4fa75b0) to head (ab5f8f6).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1088   +/-   ##
=======================================
  Coverage   89.52%   89.52%           
=======================================
  Files         677      677           
  Lines       42703    42703           
=======================================
+ Hits        38229    38231    +2     
+ Misses       4474     4472    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brant-livefront brant-livefront merged commit 17ae8bc into main Oct 29, 2024
9 checks passed
@brant-livefront brant-livefront deleted the brant/BITAU-177-add-default-for-accountdomain branch October 29, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants