[BITAU-177] Add Default for accountDomain #1088
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
BITAU-177
📔 Objective
In the Authenticator app, we use
accountEmail
andaccountDomain
to format the user's section heading to show them where the specifics codes came from in the PM app. As we were building that, I noticed thataccountEmail
should really never benil
and made the change to fetch it so that it always has a value. Similarly,account.settings.environmentUrls?.webVaultHost
should likely not benil
, but elsewhere in the app we additionally add a fallback value ofConstants.defaultWebVaultHost
.I had made a Jira ticket to move both
accountEmail
andaccountDomain
to be non-optional in our data model. However, I don't think we need to take that drastic a step and it would cause issues with the temporary item implementation. But I did want to put up this PR to make sure we provide the fallback value just in case.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes