Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-14032 - Can't Scroll Search Results in Autofill App Extension #1087

Conversation

phil-livefront
Copy link
Collaborator

@phil-livefront phil-livefront commented Oct 28, 2024

🎟️ Tracking

PM-14032

📔 Objective

  • When searching for an item in the autofill extension, the results would appear, but we couldn’t scroll to view all items in the list. This fix updates the view logic to group views consistently and add the scroll view only once, ensuring it applies to all states rendered in this view.
  • Fixed showing the FAB when searching for an item
  • Noticed theres a brief moment when loading this view that the empty view shows for a split second. I think we should update this to use a LoadingView but that felt out of scope of this particular bug so I can create a ticket to address that.
  • Fixed a linter warning I caused in my last PR 🥇

📸 Screenshots

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-28.at.18.20.02.mp4

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

…view - fixed linter warnings from previous commit
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.53%. Comparing base (4fa75b0) to head (e60ce00).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1087   +/-   ##
=======================================
  Coverage   89.52%   89.53%           
=======================================
  Files         677      677           
  Lines       42703    42705    +2     
=======================================
+ Hits        38229    38234    +5     
+ Misses       4474     4471    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phil-livefront phil-livefront marked this pull request as ready for review October 28, 2024 21:11
@phil-livefront phil-livefront marked this pull request as draft October 28, 2024 21:40
@phil-livefront phil-livefront marked this pull request as ready for review October 28, 2024 22:22
@phil-livefront phil-livefront marked this pull request as draft October 28, 2024 22:29
@phil-livefront phil-livefront marked this pull request as ready for review October 29, 2024 14:49
@phil-livefront phil-livefront merged commit 1622d6e into main Oct 29, 2024
9 checks passed
@phil-livefront phil-livefront deleted the phil/PM-14032-Can't-Scroll-Search-Results-in-Autofill-App-Extension branch October 29, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants