PM-14011: Show settings badge and action card when dismissing import logins action card from vault #1077
Conversation
…logins action card from vault
matt-livefront
requested review from
phil-livefront,
victor-livefront,
brant-livefront and
a team
as code owners
|
No New Or Fixed Issues Found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1077 +/- ##
==========================================
+ Coverage 89.47% 89.48% +0.01%
==========================================
Files 675 675
Lines 42494 42536 +42
==========================================
+ Hits 38021 38064 +43
+ Misses 4473 4472 -1 ☔ View full report in Codecov by Sentry. |
| @@ -399,7 +399,7 @@ class VaultListProcessorTests: BitwardenTestCase { // swiftlint:disable:this typ | |||
| func test_perform_dismissSetUpUnlockActionCard_error() async { | |||
| await subject.perform(.dismissImportLoginsActionCard) | |||
|
|
|||
| XCTAssertEqual(coordinator.alertShown, [.defaultAlert(title: Localizations.anErrorHasOccurred)]) | |||
| XCTAssertEqual(coordinator.alertShown, [.defaultAlert(error: StateServiceError.noActiveAccount)]) | |||
There was a problem hiding this comment.
🤔 Given that we have a specific error in mind, it might be worth noting the specific error in the test comments.
There was a problem hiding this comment.
I guess I'm not necessarily looking for this specific error, really any error should create an alert and error log, it just happens that this is the easiest error to generate. But I can note this error in the test comments if it's helpful.
There was a problem hiding this comment.
Ah, okay, then that's fine.
🎟️ Tracking
PM-14011
📔 Objective
Dismissing the vault's import logins action card should hide the card and then show the settings badge and action card for import logins.
📸 Screenshots
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-24.at.15.28.12.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes