Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-13433: Import login flow from settings #1066

Merged
merged 4 commits into from
Oct 23, 2024

Conversation

matt-livefront
Copy link
Collaborator

@matt-livefront matt-livefront commented Oct 22, 2024

🎟️ Tracking

PM-13433

📔 Objective

Adds the import logins flow to settings, if the user decides to import their logins later from the vault's action card. I moved the import logins flow into a separate coordinator to ease sharing this between the vault and settings.

📸 Screenshots

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-22.at.12.59.21.mp4

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Oct 22, 2024

Logo
Checkmarx One – Scan Summary & Details8ad8c8cb-0509-4bb0-9539-3c7cda781a15

No New Or Fixed Issues Found

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 99.13793% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.40%. Comparing base (cee1ad4) to head (33a881a).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...latform/Application/Views/ToastDisplayHelper.swift 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1066      +/-   ##
==========================================
+ Coverage   89.37%   89.40%   +0.03%     
==========================================
  Files         672      674       +2     
  Lines       42364    42438      +74     
==========================================
+ Hits        37861    37941      +80     
+ Misses       4503     4497       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from matt/PM-13885-import-logins-empty to main October 22, 2024 20:23
@matt-livefront matt-livefront merged commit 9ae99da into main Oct 23, 2024
9 checks passed
@matt-livefront matt-livefront deleted the matt/PM-13433-import-logins-settings branch October 23, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants