generated from bitwarden/template
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PM-13467: Add import saved logins action card and badge to vault settings #1055
Merged
matt-livefront
merged 9 commits into
main
from
matt/PM-13467-settings-import-login-card
Oct 22, 2024
Merged
PM-13467: Add import saved logins action card and badge to vault settings #1055
matt-livefront
merged 9 commits into
main
from
matt/PM-13467-settings-import-login-card
Oct 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-livefront
requested review from
phil-livefront,
victor-livefront,
brant-livefront and
a team
as code owners
October 17, 2024 21:07
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1055 +/- ##
=======================================
Coverage 89.34% 89.34%
=======================================
Files 671 672 +1
Lines 42166 42253 +87
=======================================
+ Hits 37672 37753 +81
- Misses 4494 4500 +6 ☔ View full report in Codecov by Sentry. |
No New Or Fixed Issues Found |
fedemkr
reviewed
Oct 17, 2024
BitwardenShared/UI/Platform/Settings/Settings/SettingsState.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/UI/Platform/Settings/Settings/Vault/VaultSettingsProcessor.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/UI/Platform/Settings/Settings/Vault/VaultSettingsState.swift
Outdated
Show resolved
Hide resolved
fedemkr
previously approved these changes
Oct 22, 2024
phil-livefront
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-13467
📔 Objective
Adds the settings badge and Settings > Vault action card for import logins.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes