Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-13467: Add import saved logins action card and badge to vault settings #1055

Merged
merged 9 commits into from
Oct 22, 2024

Conversation

matt-livefront
Copy link
Collaborator

@matt-livefront matt-livefront commented Oct 17, 2024

🎟️ Tracking

PM-13467

📔 Objective

Adds the settings badge and Settings > Vault action card for import logins.

📸 Screenshots

Screenshot 2024-10-17 at 4 02 31 PM Screenshot 2024-10-17 at 4 02 34 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 95.60440% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.34%. Comparing base (f2c65ac) to head (9b69ebf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ttings/Settings/Vault/VaultSettingsProcessor.swift 90.00% 3 Missing ⚠️
...enShared/Core/Platform/Services/StateService.swift 91.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1055   +/-   ##
=======================================
  Coverage   89.34%   89.34%           
=======================================
  Files         671      672    +1     
  Lines       42166    42253   +87     
=======================================
+ Hits        37672    37753   +81     
- Misses       4494     4500    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 17, 2024

Logo
Checkmarx One – Scan Summary & Details6a1742bc-e92a-4743-bbf1-bfc234bd92cd

No New Or Fixed Issues Found

fedemkr
fedemkr previously approved these changes Oct 22, 2024
@matt-livefront matt-livefront merged commit 8bcb21f into main Oct 22, 2024
9 checks passed
@matt-livefront matt-livefront deleted the matt/PM-13467-settings-import-login-card branch October 22, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants