Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BITAU-155] Deep link to Settings Account Security screen #1052

Conversation

brant-livefront
Copy link
Collaborator

🎟️ Tracking

BITAU-155

📔 Objective

This PR adds the ability to handle a deep link into the Settings -> Account Security screen: bitwarden://settings/account_security. It refactors the openURL method in AppProcessor slightly to clearly delineate bitwarden:// URLs from otpauth:// URLs.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.32%. Comparing base (59f4f6c) to head (e1e8835).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1052   +/-   ##
=======================================
  Coverage   89.32%   89.32%           
=======================================
  Files         671      671           
  Lines       42176    42196   +20     
=======================================
+ Hits        37672    37692   +20     
  Misses       4504     4504           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 17, 2024

Logo
Checkmarx One – Scan Summary & Details9f80cbf5-2849-4311-9682-70630265bd0e

No New Or Fixed Issues Found

Copy link
Collaborator

@victor-livefront victor-livefront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Next up are changes to the Auth app to send this Deep link path, right?

@brant-livefront
Copy link
Collaborator Author

Looks good. Next up are changes to the Auth app to send this Deep link path, right?

Yep 💯 I actually put a commit on the end of this PR: bitwarden/authenticator-ios#170
That updates our ExternalLinkConstants to have this official link. 👍

@brant-livefront brant-livefront merged commit 0bc7109 into main Oct 19, 2024
9 checks passed
@brant-livefront brant-livefront deleted the brant/BITAU-155-deep-link-to-settings-account-security-screen branch October 19, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants