-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BITAU-155] Deep link to Settings Account Security screen #1052
[BITAU-155] Deep link to Settings Account Security screen #1052
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1052 +/- ##
=======================================
Coverage 89.32% 89.32%
=======================================
Files 671 671
Lines 42176 42196 +20
=======================================
+ Hits 37672 37692 +20
Misses 4504 4504 ☔ View full report in Codecov by Sentry. |
No New Or Fixed Issues Found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Next up are changes to the Auth app to send this Deep link path, right?
Yep 💯 I actually put a commit on the end of this PR: bitwarden/authenticator-ios#170 |
…t-security-screen
…ettings-account-security-screen
…L method to be a bit tighter.
…t-security-screen
…t-security-screen
🎟️ Tracking
BITAU-155
📔 Objective
This PR adds the ability to handle a deep link into the Settings -> Account Security screen:
bitwarden://settings/account_security
. It refactors the openURL method in AppProcessor slightly to clearly delineatebitwarden://
URLs fromotpauth://
URLs.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes