-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BITAU-139] Add Menu Item to Turn on Authenticator Sync #1048
[BITAU-139] Add Menu Item to Turn on Authenticator Sync #1048
Conversation
No New Or Fixed Issues Found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1048 +/- ##
=======================================
Coverage 89.29% 89.30%
=======================================
Files 670 670
Lines 42056 42093 +37
=======================================
+ Hits 37553 37590 +37
Misses 4503 4503 ☔ View full report in Codecov by Sentry. |
BitwardenShared/UI/Platform/Settings/Settings/AccountSecurity/AccountSecurityViewTests.swift
Show resolved
Hide resolved
state.isAuthenticatorSyncEnabled = try await services.stateService.getSyncToAuthenticator() | ||
state.shouldShowAuthenticatorSyncSection = | ||
await services.configService.getFeatureFlag(.enableAuthenticatorSync) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎨 Even though it may be a little, we can improve the performance of loading this if the feature flag is off then we don't need to call try await services.stateService.getSyncToAuthenticator()
; so:
state.isAuthenticatorSyncEnabled = try await services.stateService.getSyncToAuthenticator() | |
state.shouldShowAuthenticatorSyncSection = | |
await services.configService.getFeatureFlag(.enableAuthenticatorSync) | |
state.shouldShowAuthenticatorSyncSection = | |
await services.configService.getFeatureFlag(.enableAuthenticatorSync) | |
if state.shouldShowAuthenticatorSyncSection { | |
state.isAuthenticatorSyncEnabled = try await services.stateService.getSyncToAuthenticator() | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Good optimization. Added that in the latest commit.
🎟️ Tracking
BITAU-139
📔 Objective
This PR adds a section to the Settings -> Account Security screen that includes a toggle to turn the sync with Authenticator. This is hidden behind the feature flag. Therefore, it should not affect this view in any way unless the feature flag is turned on. When it's turned on, you can use this to turn on sync for the current account (which will kick off the syncing process).
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes