Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-11159: Add vault sync for importing logins #1047

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

matt-livefront
Copy link
Collaborator

@matt-livefront matt-livefront commented Oct 15, 2024

🎟️ Tracking

PM-11159

📔 Objective

On the last import logins page, hitting Continue should sync the user's vault. This adds the sync call and loading overlay. Navigation to the success page will be in a separate PR.

📸 Screenshots

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-15.at.11.40.03.mp4

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.22%. Comparing base (c0b6360) to head (cf5ea70).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1047      +/-   ##
==========================================
- Coverage   89.22%   89.22%   -0.01%     
==========================================
  Files         665      665              
  Lines       41786    41799      +13     
==========================================
+ Hits        37283    37294      +11     
- Misses       4503     4505       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsaad7e917-7dac-4df3-b587-8ed33b7e7e24

No New Or Fixed Issues Found

@matt-livefront matt-livefront merged commit edbe5f6 into main Oct 16, 2024
9 checks passed
@matt-livefront matt-livefront deleted the matt/PM-11159-import-logins-vault-sync branch October 16, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants