Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-12783: Trim whitespace from email during registration #1027

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

matt-livefront
Copy link
Collaborator

@matt-livefront matt-livefront commented Oct 9, 2024

🎟️ Tracking

PM-12783

📔 Objective

The user's entered email wasn't being trimmed previously, which led to incorrect formatting on the check email screen.

📸 Screenshots

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-09.at.11.55.18.mp4

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Logo
Checkmarx One – Scan Summary & Details58d3b176-366e-4ba6-9d86-9fe783f12473

No New Or Fixed Issues Found

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.10%. Comparing base (d5979fa) to head (35d49cd).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1027   +/-   ##
=======================================
  Coverage   89.10%   89.10%           
=======================================
  Files         660      660           
  Lines       41364    41364           
=======================================
+ Hits        36856    36858    +2     
+ Misses       4508     4506    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matt-livefront matt-livefront merged commit 5b61ea8 into main Oct 9, 2024
9 checks passed
@matt-livefront matt-livefront deleted the matt/PM-12783-email-whitespace branch October 9, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants