Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-10803 - Implement landscape 'Turn on autofill' view #1023

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

phil-livefront
Copy link
Collaborator

@phil-livefront phil-livefront commented Oct 8, 2024

🎟️ Tracking

PM-10803

📔 Objective

  • Set up the landscape view ui for PasswordAutoFillView
  • Fixed some linter warnings I noticed

📸 Screenshots

PasswordAutoFillLandscape.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.08%. Comparing base (f242d64) to head (7943751).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ore/Platform/Services/API/Errors/ServerError.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1023   +/-   ##
=======================================
  Coverage   89.07%   89.08%           
=======================================
  Files         660      660           
  Lines       41304    41328   +24     
=======================================
+ Hits        36793    36817   +24     
  Misses       4511     4511           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 8, 2024

Logo
Checkmarx One – Scan Summary & Details67ec05f4-ed5a-45eb-a0f8-1021871ca50f

No New Or Fixed Issues Found

Copy link
Collaborator

@matt-livefront matt-livefront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@phil-livefront phil-livefront merged commit 068bed5 into main Oct 9, 2024
9 checks passed
@phil-livefront phil-livefront deleted the phil/PM-10803-password-autofill-view-landscape branch October 9, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants