PM-12736: Dismiss badge for autofill once enabled #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-livefront
requested review from
fedemkr,
phil-livefront and
KatherineInCode
matt-livefront
requested review from
victor-livefront,
brant-livefront and
a team
as code owners
matt-livefront
commented
Oct 8, 2024
| @@ -77,6 +83,10 @@ public class AppProcessor { | |||
| for await _ in services.notificationCenterService.willEnterForegroundPublisher() { | |||
| startEventTimer() | |||
| await checkAccountsForTimeout() | |||
| await completeAutofillAccountSetupIfEnabled() | |||
There was a problem hiding this comment.
ℹ️ This was the primary change here, adding this check when the app is foregrounded.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1020 +/- ##
=======================================
Coverage 89.09% 89.10%
=======================================
Files 660 660
Lines 41354 41364 +10
=======================================
+ Hits 36846 36858 +12
+ Misses 4508 4506 -2 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
fedemkr
previously approved these changes
Oct 8, 2024
phil-livefront
previously approved these changes
Oct 8, 2024
Base automatically changed from
matt/PM-12780-vault-unlock-action-card-get-started
to
main
October 8, 2024 21:17
matt-livefront
dismissed stale reviews from phil-livefront and fedemkr
The base branch was changed.
matt-livefront
force-pushed
the
matt/PM-12736-dismiss-settings-badges
branch
from
826b6c9
to
a2c95a6
Compare
phil-livefront
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-12736
📔 Objective
Dismisses the autofill badge if the app is foregrounded and the autofill extension is enabled. Previously this was only happening on start up or when the autofill view was open.
📸 Screenshots
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-08.at.12.38.55.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes