Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using label enforcement and clean up shared workflow #298

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

withinfocus
Copy link
Contributor

@withinfocus withinfocus commented Jul 17, 2024

๐ŸŽŸ๏ธ Tracking

Internal change.

๐Ÿ“” Objective

See bitwarden/template#97. We no longer use the needs-qa label and won't automate checks like this by default. Since this may be referenced in existing repos that used the template, it supports a simpler shared workflow just for the hold label.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@withinfocus withinfocus marked this pull request as ready for review July 17, 2024 21:28
@withinfocus withinfocus requested a review from a team as a code owner July 17, 2024 21:28
@bitwarden-bot
Copy link

bitwarden-bot commented Jul 17, 2024

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 860ae2eb-6fec-49b0-b7e7-dbadf8621a56

No New Or Fixed Issues Found

@withinfocus withinfocus merged commit 2da8ed1 into main Jul 18, 2024
2 checks passed
@withinfocus withinfocus deleted the nml branch July 18, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants