Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NSIS custom installer script for UAC fix on Windows #2856

Merged
merged 2 commits into from
Jun 8, 2022

Conversation

vgrassia
Copy link
Member

@vgrassia vgrassia commented Jun 7, 2022

Resolves https://bitwarden.atlassian.net/browse/PS-792

Type of change

- [X] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

This PR fixes our Windows installer from removing Bitwarden and crashing before installing the new version.

Found the fix here: electron-userland/electron-builder#2363 (comment)

Code changes

  • apps/desktop/electron-builder.json: Adds the include key to our nsis config to specify the custom installer script
  • apps/desktop/installer.nsh: Custom installer script that fixes the issue of prompting for UAC when Bitwarden is installed for All Users

Before you submit

- [ ] I have checked for **linting** errors (`npm run lint`) (required)
- [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required)
- [ ] This change requires a **documentation update** (notify the documentation team)
- [ ] This change has particular **deployment requirements** (notify the DevOps team)

@vgrassia vgrassia requested a review from a team June 7, 2022 20:19
@vgrassia vgrassia self-assigned this Jun 7, 2022
@vgrassia vgrassia merged commit 3d4c5fe into master Jun 8, 2022
@vgrassia vgrassia deleted the fix/nsis-installer-script branch June 8, 2022 12:47
vgrassia added a commit that referenced this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants