Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16898] remove jslib services #12873

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

audreyality
Copy link
Member

@audreyality audreyality commented Jan 14, 2025

๐Ÿ›‘ Hold

This PR is blocked until I18nPipe, safeProvider and SafeInjectionToken are moved from @bitwarden/angular to a lower-level library.

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-16898

๐Ÿ“” Objective

Eliminate circular dependencies from @bitwarden/generator-components module to prepare for npm modularization.

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@audreyality audreyality added the hold do not merge, do not approve yet label Jan 14, 2025
Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 8725e17b-9664-4c8e-98db-2c856c0364f0

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 34.27%. Comparing base (553d20f) to head (c6fec2e).

โœ… All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12873      +/-   ##
==========================================
- Coverage   34.28%   34.27%   -0.01%     
==========================================
  Files        2935     2935              
  Lines       90229    90229              
  Branches    16943    16943              
==========================================
- Hits        30937    30930       -7     
- Misses      56828    56835       +7     
  Partials     2464     2464              

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold do not merge, do not approve yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant