[PM-8221] Route user to email OTP entry [clients] #12811
+852
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3db8357.
…of processing (2) processDeviceVerificationResponse should cache data
… (2) Update form to use bitSubmit (3) Add todo for authenticating guard
|
Great job, no security vulnerabilities found in this Pull Request |
…ttps://github.com/bitwarden/clients into auth/pm-8221/route-user-to-email-otp-entry-clients
JaredSnider-Bitwarden
requested changes
Jan 15, 2025
libs/auth/src/common/services/login-strategies/login-strategy.service.ts
Outdated
Show resolved
Hide resolved
…ttps://github.com/bitwarden/clients into auth/pm-8221/route-user-to-email-otp-entry-clients
JaredSnider-Bitwarden
requested changes
Jan 21, 2025
libs/angular/src/auth/components/two-factor-auth/two-factor-auth-expired.component.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-8221?atlOrigin=eyJpIjoiOTdiY2RkOWIwYmFhNDUyMGI1MDA3MDM0M2ZkMGI1OTkiLCJwIjoiaiJ9
📔 Objective
Add an intermediate route (
/device-verification) that requires a user to enter an OTP to proceed to the vault when they are attempting to log in on an unknown device.📸 Screenshots
Web
GMT20250110-202812_Clip_Alec.Rippberger.s.Clip.01_10_2025.mp4
Desktop
GMT20250110-200921_Clip_Alec.Rippberger.s.Clip.01_10_2025.mp4
Browser Extension
GMT20250110-192642_Clip_Alec.Rippberger.s.Clip.01_10_2025.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes