[PM-11360] Remove export permission for providers #12062
Conversation
…ult-export-permission-for-providers
This reverts commit 0cf1f23.
eliykat
changed the title
There was a problem hiding this comment.
Tools Team: this is just updating the org.canAccessImportExport property reference, which has been split into org.canAccessImport and org.canAccessExport. Given that this is the import component, it now refers to org.canAccessImport.
| canAccessImport(this.i18nService), | ||
| map((orgs) => orgs.filter((org) => org.canAccessImport)), | ||
| map((orgs) => orgs.sort(Utils.getSortFunction(this.i18nService, "name"))), |
There was a problem hiding this comment.
The canAccessImport helper function in organization.service.abstraction has also been removed because it was only used here and this is all it was doing.
| ); | ||
| } | ||
|
|
||
| canAccessExport(removeProviderExport: boolean) { |
There was a problem hiding this comment.
It's a bit awkward to make callers fetch their own feature flag value to pass in. I tried some other approaches, but introducing any observable or promise here makes pretty large waves through all its callers. This remains the simplest approach for now.
|
Fixed Issues
|
| } | ||
|
|
||
| return ( | ||
| this.isMember && |
There was a problem hiding this comment.
This is necessary because some of our model mapping is wrong. I've logged a bug here: https://bitwarden.atlassian.net/browse/PM-15078
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12062 +/- ##
=======================================
Coverage 33.44% 33.45%
=======================================
Files 2864 2864
Lines 89666 89667 +1
Branches 17067 17067
=======================================
+ Hits 29988 29997 +9
+ Misses 57317 57309 -8
Partials 2361 2361 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
eliykat
dismissed stale reviews from vleague2, r-tome, and audreyality
via
f0acba9
|
I had to fix some mocks used in Storybook. The remaining 1 story change is an unapproved change from |
eliykat
deleted the
ac/pm-11360/remove-vault-export-permission-for-providers
branch
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-11360
📔 Objective
Remove provider export permissions. Provider users will not have the ability to access an organization’s export tab or export a managed organization’s items.
organization.canAccessImportExportinto separate getters for import and export (providers can still import)Server PR: bitwarden/server#5051
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes