Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BWA-19] Add Backup setting #98

Merged
merged 2 commits into from
May 23, 2024
Merged

[BWA-19] Add Backup setting #98

merged 2 commits into from
May 23, 2024

Conversation

KatherineInCode
Copy link
Contributor

@KatherineInCode KatherineInCode commented May 21, 2024

๐ŸŽŸ๏ธ Tracking

BWA-19

๐Ÿ“” Objective

This adds a "Backup" button on the Settings screen that when tapped pops up an alert explaining that the system backup is used, along with a link to the Apple page for turning on iCloud

๐Ÿ“ธ Screenshots

Simulator Screenshot - iPhone 15 Pro - 2024-05-21 at 11 44 05

Simulator Screenshot - iPhone 15 Pro - 2024-05-21 at 11 44 08

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@KatherineInCode KatherineInCode marked this pull request as ready for review May 21, 2024 16:48
@KatherineInCode KatherineInCode requested a review from a team as a code owner May 21, 2024 16:48
Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 00eb3eba-52a3-46a1-989e-e7fa9448d36d

No New Or Fixed Issues Found

@KatherineInCode KatherineInCode merged commit 6210ec8 into main May 23, 2024
8 checks passed
@KatherineInCode KatherineInCode deleted the bwa-19/backup-setting branch May 23, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants