Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused localizable strings #90

Merged
merged 3 commits into from
May 13, 2024
Merged

Conversation

KatherineInCode
Copy link
Contributor

📔 Objective

This removes localizable strings that were not actually in use along with some unused alerts. This lays some groundwork for integrating with Crowdin.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsa4b3eba3-0415-4d3e-9561-9ca5486eb4b5

No New Or Fixed Issues Found

@KatherineInCode KatherineInCode marked this pull request as ready for review May 10, 2024 16:14
@KatherineInCode KatherineInCode requested a review from a team as a code owner May 10, 2024 16:14
@KatherineInCode KatherineInCode merged commit ed69f7a into main May 13, 2024
7 checks passed
@KatherineInCode KatherineInCode deleted the clean-localizable branch May 13, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants