Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BWA-1] Remove biometrics integrity check so users don't get locked out #88

Merged
merged 2 commits into from
May 9, 2024

Conversation

KatherineInCode
Copy link
Contributor

@KatherineInCode KatherineInCode commented May 9, 2024

🎟️ Tracking

BWA-1

📔 Objective

This removes the biometrics integrity check before asking for them—this prevents users from getting locked out if they e.g. reset their FaceID

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@KatherineInCode KatherineInCode marked this pull request as ready for review May 9, 2024 04:02
@KatherineInCode KatherineInCode requested a review from a team as a code owner May 9, 2024 04:02
Copy link
Contributor

github-actions bot commented May 9, 2024

Logo
Checkmarx One – Scan Summary & Details94a26f4b-9794-447a-8b04-14f5dd687928

No New Or Fixed Issues Found

Copy link
Contributor

github-actions bot commented May 9, 2024

2 Warnings
⚠️ Ignoring duplicate libraries: '-lbitwarden_uniffi'
⚠️ AuthenticatorShared/UI/Vault/ItemList/ItemList/ItemListView.swift#L295: Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 262 lines (type_body_length)
3 Messages
📖 AuthenticatorSharedTests: Executed 263 tests, with 3 failures (0 expected) in 12.546 (12.736) seconds
📖 AuthenticatorTests: Executed 0 tests, with 0 failures (0 expected) in 0 (0.001) seconds
📖 NetworkingTests: Executed 26 tests, with 0 failures (0 expected) in 0.083 (0.098) seconds

Authenticator code coverage

Total coverage: 55.54%

File Coverage
AuthenticatorShared/UI/Auth/VaultUnlock/VaultUnlockProcessor.swift 0.00%

Powered by Slather

Generated by 🚫 Danger

@KatherineInCode KatherineInCode merged commit 857ab52 into main May 9, 2024
8 checks passed
@KatherineInCode KatherineInCode deleted the bwa-1-remove-integrity-check branch May 9, 2024 19:13
@KatherineInCode KatherineInCode linked an issue May 23, 2024 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App broken after migrating to new device
2 participants