Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define issue template for bugs #86

Merged
merged 3 commits into from
May 9, 2024
Merged

Define issue template for bugs #86

merged 3 commits into from
May 9, 2024

Conversation

KatherineInCode
Copy link
Contributor

📔 Objective

Define a template for bug reports.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@KatherineInCode KatherineInCode marked this pull request as ready for review May 8, 2024 12:57
@KatherineInCode KatherineInCode requested a review from a team as a code owner May 8, 2024 12:57
Copy link
Contributor

github-actions bot commented May 8, 2024

Logo
Checkmarx One – Scan Summary & Details427d3816-f636-421c-84ec-569ba4fe3c46

No New Or Fixed Issues Found

Copy link
Contributor

github-actions bot commented May 8, 2024

2 Warnings
⚠️ Ignoring duplicate libraries: '-lbitwarden_uniffi'
⚠️ AuthenticatorShared/UI/Vault/ItemList/ItemList/ItemListView.swift#L295: Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 262 lines (type_body_length)
3 Messages
📖 AuthenticatorSharedTests: Executed 263 tests, with 3 failures (0 expected) in 13.093 (13.331) seconds
📖 AuthenticatorTests: Executed 0 tests, with 0 failures (0 expected) in 0 (0.001) seconds
📖 NetworkingTests: Executed 26 tests, with 0 failures (0 expected) in 0.06 (0.074) seconds

Authenticator code coverage

Total coverage: 56.00%

Powered by Slather

Generated by 🚫 Danger

description: |
Issue tracking information
options:
- label: I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛏️ End files in newlines.

@KatherineInCode KatherineInCode merged commit 1971233 into main May 9, 2024
8 checks passed
@KatherineInCode KatherineInCode deleted the bug-template branch May 9, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants