-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BITAU-124] Refresh Item List When Foregrounding the App #178
[BITAU-124] Refresh Item List When Foregrounding the App #178
Conversation
…local-items; Fix conflicts
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
==========================================
+ Coverage 67.24% 67.32% +0.07%
==========================================
Files 213 214 +1
Lines 9473 9505 +32
==========================================
+ Hits 6370 6399 +29
- Misses 3103 3106 +3 ☔ View full report in Codecov by Sentry. |
AuthenticatorShared/UI/Vault/ItemList/ItemList/ItemListProcessorTests.swift
Show resolved
Hide resolved
AuthenticatorShared/Core/Platform/Services/NotificationCenterService.swift
Show resolved
Hide resolved
AuthenticatorShared/Core/Platform/Services/NotificationCenterService.swift
Show resolved
Hide resolved
⛏️ Could the PR title be changed to fix the typo? |
AuthenticatorShared/Core/Platform/Services/NotificationCenterService.swift
Show resolved
Hide resolved
AuthenticatorShared/Core/Platform/Services/NotificationCenterService.swift
Show resolved
Hide resolved
…ry-for-adding-to-bitwarden
…o-bitwarden' into brant/BITAU-124-refersh-item-list-when-foregrounding-the-app
…ry-for-adding-to-bitwarden
…ng-to-bitwarden' into brant/BITAU-131-add-popup-to-qr-code-scan-to-add-code-to-bitwarden
…o-bitwarden' into brant/BITAU-124-refersh-item-list-when-foregrounding-the-app
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one minor pick but leave it up to you whether to change it.
AuthenticatorShared/UI/Vault/ItemList/ItemList/ItemListProcessor.swift
Outdated
Show resolved
Hide resolved
No New Or Fixed Issues Found |
The base branch was changed.
🎟️ Tracking
BITAU-124
📔 Objective
This PR adds the NotificationCenterService and subscribes to the publisher to refresh the ItemList when the user returns to the app. Previously, if you made changes in the Bitwarden PM app and then switched back to the Authenticator, it would not have picked up those changes immediately. By subscribing to the foreground notification and performing a
.refresh
action, the user's latest changes from the PM app are immediately processed and shown.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes