Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BITAU-124] Refresh Item List When Foregrounding the App #178

Conversation

brant-livefront
Copy link
Collaborator

🎟️ Tracking

BITAU-124

📔 Objective

This PR adds the NotificationCenterService and subscribes to the publisher to refresh the ItemList when the user returns to the app. Previously, if you made changes in the Bitwarden PM app and then switched back to the Authenticator, it would not have picked up those changes immediately. By subscribing to the foreground notification and performing a .refresh action, the user's latest changes from the PM app are immediately processed and shown.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 90.62500% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.32%. Comparing base (5a699f3) to head (d01ffd1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ared/Core/Platform/Services/ServiceContainer.swift 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
+ Coverage   67.24%   67.32%   +0.07%     
==========================================
  Files         213      214       +1     
  Lines        9473     9505      +32     
==========================================
+ Hits         6370     6399      +29     
- Misses       3103     3106       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KatherineInCode
Copy link
Contributor

⛏️ Could the PR title be changed to fix the typo?

@brant-livefront brant-livefront changed the title [BITAU-124] Refersh Item List When Foregrounding the App [BITAU-124] Refresh Item List When Foregrounding the App Oct 30, 2024
…ng-to-bitwarden' into brant/BITAU-131-add-popup-to-qr-code-scan-to-add-code-to-bitwarden
…o-bitwarden' into brant/BITAU-124-refersh-item-list-when-foregrounding-the-app
Copy link
Member

@fedemkr fedemkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor pick but leave it up to you whether to change it.

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Logo
Checkmarx One – Scan Summary & Detailsf7981c3f-bcd4-4c35-9163-4475162fddb3

No New Or Fixed Issues Found

fedemkr
fedemkr previously approved these changes Nov 7, 2024
Base automatically changed from brant/BITAU-131-add-popup-to-qr-code-scan-to-add-code-to-bitwarden to main November 7, 2024 15:06
@brant-livefront brant-livefront dismissed fedemkr’s stale review November 7, 2024 15:06

The base branch was changed.

@brant-livefront brant-livefront merged commit a84c21d into main Nov 7, 2024
9 checks passed
@brant-livefront brant-livefront deleted the brant/BITAU-124-refersh-item-list-when-foregrounding-the-app branch November 7, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants