-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BITAU-131] Add Popup to QR Code Scan to Add Code to Bitwarden #177
Merged
brant-livefront
merged 18 commits into
main
from
brant/BITAU-131-add-popup-to-qr-code-scan-to-add-code-to-bitwarden
Nov 7, 2024
Merged
[BITAU-131] Add Popup to QR Code Scan to Add Code to Bitwarden #177
brant-livefront
merged 18 commits into
main
from
brant/BITAU-131-add-popup-to-qr-code-scan-to-add-code-to-bitwarden
Nov 7, 2024
+821
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…local-items; Fix conflicts
brant-livefront
requested review from
fedemkr,
victor-livefront and
KatherineInCode
October 28, 2024 20:48
AuthenticatorShared/UI/Platform/Settings/Settings/SettingsProcessor.swift
Outdated
Show resolved
Hide resolved
...ettings/__Snapshots__/SettingsViewTests/test_viewRenderWithSyncRowAndDefaultSaveOption.2.png
Outdated
Show resolved
Hide resolved
AuthenticatorShared/UI/Vault/ItemList/ItemList/ItemListProcessorTests.swift
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
==========================================
+ Coverage 67.09% 67.24% +0.14%
==========================================
Files 211 213 +2
Lines 9300 9473 +173
==========================================
+ Hits 6240 6370 +130
- Misses 3060 3103 +43 ☔ View full report in Codecov by Sentry. |
AuthenticatorShared/UI/Platform/Application/Support/Localizations/en.lproj/Localizable.strings
Outdated
Show resolved
Hide resolved
AuthenticatorShared/UI/Vault/ItemList/ItemList/ItemListProcessor.swift
Outdated
Show resolved
Hide resolved
…ry-for-adding-to-bitwarden
…ry-for-adding-to-bitwarden
…ng-to-bitwarden' into brant/BITAU-131-add-popup-to-qr-code-scan-to-add-code-to-bitwarden
fedemkr
reviewed
Nov 6, 2024
...ettings/__Snapshots__/SettingsViewTests/test_viewRenderWithSyncRowAndDefaultSaveOption.2.png
Outdated
Show resolved
Hide resolved
Base automatically changed from
brant/BITAU-130-add-option-to-manual-key-entry-for-adding-to-bitwarden
to
main
November 6, 2024 22:06
No New Or Fixed Issues Found |
fedemkr
approved these changes
Nov 7, 2024
brant-livefront
deleted the
brant/BITAU-131-add-popup-to-qr-code-scan-to-add-code-to-bitwarden
branch
November 7, 2024 15:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
BITAU-131
📔 Objective
The main objective of this PR is to add the ability to save QR code scans in the Bitwarden PM app when they originate from the Authenticator app. There's a couple of pieces in support of this:
defaultSaveOption
- this records where the user wants to save codes by default (locally, in Bitwarden, or ask each time)hasSeenDefaultSaveOptionPrompt
- this tells us if they've seen the dialog asking them to set their default. We only show it once. After that, everything is controlled by thedefaultSaveOption
.defaultSaveOption
.Dialog flow
Testing notes
otpauth://
style QR code📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes