[BWA-38] Make imported 2FAS fields optional #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
=======================================
Coverage 61.97% 61.97%
=======================================
Files 199 199
Lines 6754 6754
=======================================
Hits 4186 4186
Misses 2568 2568 ☔ View full report in Codecov by Sentry. |
SaintPatrck
reviewed
Jun 12, 2024
| @@ -19,8 +19,9 @@ class GoogleImporter { | |||
| return payload.otpParameters.compactMap { item in | |||
| guard item.type == .otpTotp else { return nil } | |||
| let secret = item.secret.base32String() | |||
| // Google Authenticator current ignores algorithm and period on all platforms and digits on some platforms (but not iOS). | |||
| // Therefore, we need to use defaults and keep the digits in a reasonable range, because Google Authenticator doesn't | |||
| // Google Authenticator current ignores algorithm and period on all platforms | |||
There was a problem hiding this comment.
This change fixes the line length warning; not sure why it's showing up as still existing
SaintPatrck
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
BWA-38
📔 Objective
This adjusts the 2FAS import to make all of the "otp" fields optional, as some exports may be missing some of these fields (as opposed to having them and leaving them empty). This should improve the 2FAS import experience.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes