Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo tuneup #103

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Repo tuneup #103

merged 2 commits into from
Jun 3, 2024

Conversation

withinfocus
Copy link
Contributor

🎟️ Tracking

Internal change.

📔 Objective

Gets some things from our other native app repos and uses the latest template.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented May 31, 2024

Logo
Checkmarx One – Scan Summary & Detailsd3e26ad7-2c18-4ed5-9f31-fabfcd7a68eb

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /build.yml: [58](https://github.com/bitwarden/authenticator-ios/blob/tuneup//.github/workflows/build.yml# L58) Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /build.yml: [71](https://github.com/bitwarden/authenticator-ios/blob/tuneup//.github/workflows/build.yml# L71)

.github/workflows/build.yml Outdated Show resolved Hide resolved
@withinfocus withinfocus marked this pull request as ready for review May 31, 2024 19:40
@withinfocus withinfocus requested review from a team as code owners May 31, 2024 19:40
@withinfocus withinfocus merged commit 3b1c92b into main Jun 3, 2024
5 checks passed
@withinfocus withinfocus deleted the tuneup branch June 3, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants