PM-14805: Use network result in all Retrofit API requests

[david-livefront]

🎟️ Tracking

PM-14805

📔 Objective

This is a hotfix PR, the main PR has already been merged into main.

This PR adds a new class called NetworkResult to the app and uses it in place of Result for all network requests.

This is done to avoid a ClassCastException that can occur where the Result in unnecessarily boxed creating a Result<Result<T>>. This should not happen with the new NetworkResult.

We will continue to use the regular Result everywhere else in the app.

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
  issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – 1efbc03f-409a-4ab4-a5b8-1d9e42c2443b

New Issues

Severity	Issue	Source File / Package	Checkmarx Insight
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/data/tools/generator/repository/utils/GeneratorRepositoryExtensions.kt: 11	Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/data/autofill/manager/AutofillTotpManagerImpl.kt: 29	Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 341	Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 341	Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/deleteaccount/DeleteAccountViewModel.kt: 94	Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 240	Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 251	Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 262	Attack Vector
	Unpinned Actions Full Length Commit SHA	/crowdin-pull.yml: 26	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
	Unpinned Actions Full Length Commit SHA	/crowdin-pull.yml: 26	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
	Use_of_Hardcoded_Password	/app/src/main/java/com/x8bit/bitwarden/data/autofill/util/HtmlInfoExtensions.kt: 20	Attack Vector

[codecov]

Codecov Report

Attention: Patch coverage is 98.04688% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/hotfix-v2024.11.4@ef01f27). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...tform/datasource/network/core/NetworkResultCall.kt	73.33%	1 Missing and 3 partials ⚠️
.../datasource/network/service/AccountsServiceImpl.kt	98.14%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@                     Coverage Diff                      @@
##             release/hotfix-v2024.11.4    #4290   +/-   ##
============================================================
  Coverage                             ?   88.98%           
============================================================
  Files                                ?      440           
  Lines                                ?    38253           
  Branches                             ?     5345           
============================================================
  Hits                                 ?    34039           
  Misses                               ?     2349           
  Partials                             ?     1865           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[david-livefront]

Thanks @dseverns-livefront